🧃Juicebox DAO - fix-v1-project

@Multisig URGENT: The most recent configure transaction to the v1 project had incorrectly programmed _payoutMods, meaning the payouts would be sent into treasury itself rather than going to the V1Allocator as intended. We have disabled the Send payouts button in the frontend, and @jango is queuing a transaction to fix this by updating the payout within the current target

19:10

@Multisig get access to your wallets as soon as possible and stay on standby for a quick sign + execution.

5

https://app.safe.global/transactions/queue?safe=eth:0xAF28bcB48C40dBC86f52D459A6562F658fc94B1e

19:15

check here for ModStore contract https://docs.juicebox.money/dev/deprecated/v1/resources/contract-addresses/

19:15

i got the v1 => v3 allocator address (0x1eb759829b1a3d55193472142f18df3091BcAc4B) from tx 214 https://app.safe.global/transactions/history?safe=eth:0xA, and confirmed on our docs page (edited)

19:16

i also set the beneficiary of the transaction to 0xAF28bcB48C40dBC86f52D459A6562F658fc94B1e to copy this last tx we made to v1. it shouldnt be needed as the beneficiary property is ignored

19:16

confirm in the v1 cycle store that jbdao's current cycle has configuration 1683135083 https://etherscan.io/address/0xf507B2A1dD7439201eb07F11E1d62AfB29216e2E#readContract

coming in 5

19:17

also confirm current payout mods for this configuration is

(let me know if not the right time) Is there jbm bug that needs to be remedied here?

aeolian

(let me know if not the right time) Is there jbm bug that needs to be remedied here?

I'll see – I think updating funding target may have reset payouts, but very easily could have been a mistake I made along the way. Will see if I can reproduce later

1

19:18

Simulation https://dashboard.tenderly.co/public/safe/safe-apps/simulator/5145eea2-9453-4cae-860e-679c5a0b7c74

hey, sorry posted in wrong channel. I'm here

1

19:25

on standby, lmk when it's ready to sign

pmoncada

on standby, lmk when it's ready to sign

ready to verify and sign

jango

https://app.safe.global/transactions/queue?safe=eth:0xAF28bcB48C40dBC86f52D459A6562F658fc94B1e

this one right?

VERIFY + SIGN THIS TRANSACTION: https://app.safe.global/transactions/tx?safe=eth:0xAF28bcB48C40dBC86f52D459A6562F658fc94B1e&id=multisig_0xAF28bcB48C40dBC86f52D459A6562F658fc94B1e_0xa4061f82799c89de266baaa16e92eaf484bfba5c35bbfa175e38383faf38441e Simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/5145eea2-9453-4cae-860e-679c5a0b7c74 @Multisig

signed ✅

1

filipviz pinned a message to this channel. 05/06/2023 7:27 PM

signed!✅

Afk back in 30

Can confirm that doing a payout after the simulation above does call the V3 terminal (ignore the distributed amount I did the simulated distribution for only 100 wei) (edited)

19:44

without the simulated TX it does not call the V3 terminal/allocator like filip mention in the OP

20:07

@Multisig one more signature needed. Anybody around?

1

filipviz

@Multisig one more signature needed. Anybody around?

https://etherscan.io/tx/0xf8439e11be043ab9eff18db01968a6ead84054c3767f2f1f73f4b489a9e42b75

2

Sorry been away, can be on standby for tx in 20 min

21:03

nice work everyone. happy weekend to yall

.

2

@jango working on a post-mortem? Or should I start one? I'll check the configure flow as well.

21:18

PR to add back button: https://github.com/jbx-protocol/juice-interface/pull/3549

filipviz

@jango working on a post-mortem? Or should I start one? I'll check the configure flow as well.

please write one

good job everyone!

2

Ok bug reproduced. Will write some notes out now and create a fleshed-out post mortem tomorrow. Will include messages from this channel unless somebody objects.

4

Always keep your phone on loud - financial advice

1